Change docker build tag name and remove github action from push#1002
Merged
Conversation
Signed-off-by: Quanyi Ma <eli@patch.sh>
Signed-off-by: Quanyi Ma <eli@patch.sh>
Signed-off-by: Quanyi Ma <eli@patch.sh>
genedna
added this to the
0.1.0 - Git and LFS Migrations to Mega and P2P Protocol Implementation milestone
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR primarily updates the Docker image tag names to use the "latest" nomenclature and removes the GitHub Actions push trigger configuration. Additionally, it introduces a vendor update for the cc crate (version 1.2.20) in the third-party directory.
- Updated Docker build and run commands in docker/README.md to use new image tags.
- Revised documentation in the root README.md to match the new Docker image tags.
- Removed the push trigger configuration from .github/workflows/base.yml.
- Added the new cc crate vendor update.
Reviewed Changes
Copilot reviewed 181 out of 187 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| third-party/rust/crates/cc/1.2.20/* | Added vendor code for cc crate v1.2.20 with generated and supporting files. |
| docker/README.md | Modified Docker commands to update image tag names for postgres, mono-engine, and mono-ui. |
| README.md | Updated Docker pull and run instructions to reflect the new image tag names. |
| .github/workflows/base.yml | Removed the push-trigger configuration for GitHub Actions. |
Files not reviewed (6)
- third-party/rust/crates/cc/1.2.20/.cargo_vcs_info.json: Language not supported
- third-party/rust/crates/cc/1.2.20/.gitignore: Language not supported
- third-party/rust/crates/cc/1.2.20/BUCK: Language not supported
- third-party/rust/crates/cc/1.2.20/Cargo.toml.orig: Language not supported
- third-party/rust/crates/cc/1.2.20/LICENSE-APACHE: Language not supported
- third-party/rust/crates/cc/1.2.20/LICENSE-MIT: Language not supported
Signed-off-by: Quanyi Ma <eli@patch.sh>
Signed-off-by: Quanyi Ma <eli@patch.sh>
genedna
enabled auto-merge
May 3, 2025 09:34
benjamin-747
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.